fix: update docker-based predicate type to use updated format #1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Asra Ali <asraa@google.com>
asraa
requested review from
ianlewis,
laurentsimon and
joshuagl
as code owners
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
laurentsimon
approved these changes
Feb 8, 2023
|
Going to submit, but leaving issue open for review of completion. |
|
Nice. Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Asra Ali asraa@google.com
Partial fix #1566
Updates the docker-based build definition's external parameter structure. This is intended to hold the inputs to a docker-based build (which includes the unpacked command and artifactPath).
The issue also mentions added workflow inputs: these will be added by the workflow, and capture the inputs to the workflow run at the top level. Because they are read from GH context, I think they should be in systemParameters as trusted values alongside the rest of the GH context and workflow path.
cc @rbehjati