-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Set cosign-repository input and env #2962
feat: Set cosign-repository input and env #2962
Conversation
d10f284
to
e6a714e
Compare
56108fb
to
db8fd1a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. A few questions and nits, but looking good!
@laurentsimon Is there a way to autogenerate the readme with updated paramters for the workflow? If so, can you guide on |
There's no auto-generate :/ Does that help? |
e93891b
to
ac1d9c3
Compare
Signed-off-by: saisatishkarra <saisatish.karra@konghq.com>
Signed-off-by: saisatishkarra <saisatish.karra@konghq.com>
Signed-off-by: saisatishkarra <saisatish.karra@konghq.com>
ac1d9c3
to
5c0b0e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
@ianlewis can you take a second look before we merge?
5fa60e6
to
529b570
Compare
529b570
to
df805e8
Compare
cc: @laurentsimon / @ianlewis for some eyes!! Looking to make similar changes on the verifier with some guidance on expected direction! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Take a look at the linter failures. Should be easy to fix |
Signed-off-by: saisatishkarra <saisatish.karra@konghq.com>
3461064
to
77e4a28
Compare
Fixed linting issues and indentation. Waiting for the checks to run!! |
Signed-off-by: saisatishkarra <saisatish.karra@konghq.com>
Head branch was pushed to by a user without write access
048292d
to
1f4b072
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Ian Lewis <ianlewis@google.com> Signed-off-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com>
Thanks for your time spent on this @laurentsimon & @ianlewis |
Solves: #2956