Return an error if repo/ref not detected #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianlewis
changed the title
added 2 commits
June 23, 2022 02:10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #376
I'm not sure why but it seems that in
pull_requests(even though we don't really support them, and possibly other triggers) sometimes thedetect-workflowaction returns empty strings in the repository and/or ref outputs without producing an error. If fed directly into a latercheckoutaction this checks out the repository in thegithubcontext (not the slsa-github-generator) repo.This PR causes the
detect-workflowaction to return an error if no repository or ref are found.