update

Signed-off-by: laurentsimon <laurentsimon@google.com>
slsa-framework · Jul 10, 2023 · 32123af · 32123af
1 parent bb34cb7
commit 32123af
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 12 deletions.
diff --git a/verifiers/utils/builder.go b/verifiers/utils/builder.go
@@ -164,10 +164,10 @@ func IsValidJreleaserBuilderTag(ref string) error {
 	languages := map[string]bool{
 		"-java": true,
 	}
-	_, correctLanguage := languages[semver.Prerelease(pin)]
+	_, validLanguage := languages[semver.Prerelease(pin)]
 	if !semver.IsValid(pin) ||
 		len(strings.Split(pin, ".")) != 3 ||
-		!correctLanguage ||
+		!validLanguage ||
 		semver.Build(pin) != "" {
 		return fmt.Errorf("%w: %s: not of the form vX.Y.Z-<language>", serrors.ErrorInvalidRef, pin)
 	}

diff --git a/verifiers/utils/builder_test.go b/verifiers/utils/builder_test.go
@@ -672,11 +672,6 @@ func Test_IsValidBuilderTag(t *testing.T) {
 			ref:  "refs/tags/v1",
 			err:  serrors.ErrorInvalidRef,
 		},
-		{
-			name: "valid semver: no minor",
-			ref:  "refs/tags/v1",
-			err:  serrors.ErrorInvalidRef,
-		},
 		{
 			name: "valid semver: pre-release",
 			ref:  "refs/tags/v1.2.3-rc.0",
@@ -792,11 +787,6 @@ func Test_IsValidJreleaserBuilderTag(t *testing.T) {
 			ref:  "refs/tags/v1-java",
 			err:  serrors.ErrorInvalidRef,
 		},
-		{
-			name: "valid semver: no minor",
-			ref:  "refs/tags/v1-java",
-			err:  serrors.ErrorInvalidRef,
-		},
 		{
 			name: "valid semver: pre-release",
 			ref:  "refs/tags/v1.2.3-rc.0+java",