Skip to content

Commit

Permalink
Provenance v1: more fixes
Browse files Browse the repository at this point in the history
Signed-off-by: Mark Lodato <lodato@google.com>
  • Loading branch information
MarkLodato committed Jan 31, 2023
1 parent 2aa1061 commit dd738c5
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
2 changes: 1 addition & 1 deletion docs/github-actions-workflow/v0.1/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ repository renames and to detect when an old name is reused for a new entity.

### Resolved dependencies

The `resolvedDependencies` SHOULD contain an entry identifying the resolved the
The `resolvedDependencies` SHOULD contain an entry identifying the resolved
git commit ID corresponding to `externalParameters.workflow`. The dependency's
`uri` MUST be in [SPDX Download Location] format, i.e.
`"git+" + workflow.uri + "@" + workflow.ref`. See [Example].
Expand Down
10 changes: 8 additions & 2 deletions docs/provenance/v1/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,11 @@ This predicate follows the in-toto attestation [parsing rules]. Summary:
- Optional fields MAY be unset or null, and SHOULD be treated equivalently.
Both are equivalent to empty for _object_ or _array_ values.

> **TODO:** The [GitHub Actions] spec says that consumers MUST **reject**
> unrecognized external parameters, whereas here we say that they must
> **ignore** unrecognized fields (including parameters). We need to figure out
> which is correct and then resolve the conflict.
## Schema

_NOTE: This section describes the fields within `predicate`. For a description
Expand Down Expand Up @@ -477,7 +482,9 @@ The timestamp of when the build completed.

[Verification]: #verification

> **TODO:** Describe how clients are expected to verify the provenance.
> **TODO:** Describe how clients are expected to verify the provenance. This
> includes the idea that a verification tool can check external parameters
> without knowing the specific buildType.
## Index of build types

Expand Down Expand Up @@ -603,7 +610,6 @@ Renamed to "slsa.dev/provenance".
Initial version, named "in-toto.io/Provenance"

[Statement]: https://github.com/in-toto/attestation/blob/main/spec/README.md#statement
[DigestSet]: https://github.com/in-toto/attestation/blob/main/spec/field_types.md#DigestSet
[in-toto attestation]: https://github.com/in-toto/attestation
[parsing rules]: https://github.com/in-toto/attestation/blob/main/spec/README.md#parsing-rules
[purl]: https://github.com/package-url/purl-spec
Expand Down

0 comments on commit dd738c5

Please sign in to comment.