Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generated CSS and JS files #291

Merged
merged 4 commits into from
Jul 29, 2024
Merged

Update generated CSS and JS files #291

merged 4 commits into from
Jul 29, 2024

Conversation

sebastian-meyer
Copy link
Member

@sebastian-meyer sebastian-meyer commented Jul 22, 2024

  • Add dependency grunt-cli to Build/package.json
  • Update dependencies in Build/package-lock.json
  • Use node.js 20.x for grunt workflow
  • Update generated CSS and JS files (running grunt less & grunt terser)

This completes PR #230.

@sebastian-meyer sebastian-meyer self-assigned this Jul 22, 2024
@sebastian-meyer
Copy link
Member Author

@gnuj I did the npm update magic, but the GruntComparison build still fails. Do you have an idea what could be wrong here? Is it maybe the old Node.js version (12)?

@stweil
Copy link
Contributor

stweil commented Jul 22, 2024

Grunt 1.6.1 (in your package-lock.json) requires Node.js 14 or later.

@stweil
Copy link
Contributor

stweil commented Jul 22, 2024

It seems to work with Node.js 18, but then creates a different Resources/Public/Css/allStyles.css.map (see https://github.com/slub/dfg-viewer/actions/runs/10044988488/job/27761266962?pr=293).

@sebastian-meyer
Copy link
Member Author

Finally! Thank you for your assistance, @stweil!

@sebastian-meyer sebastian-meyer added 🐛 bug A non-security related bug. 🛠️ maintenance A task to keep the code up-to-date and manageable. and removed 🐛 bug A non-security related bug. labels Jul 23, 2024
@sebastian-meyer sebastian-meyer changed the title Update package-lock.json Update generated CSS and JS files Jul 23, 2024
@sebastian-meyer
Copy link
Member Author

GitHub doesn't allow reviewing my own PRs and also doesn't allow me to merge this without a review. Could you please have a look at this when you are back in office, @beatrycze-volk?

@gnuj
Copy link
Contributor

gnuj commented Jul 23, 2024

Good work! 👍 I also dug a little deeper yesterday and found one or two other NPM issues, which also would be solved by raising the node.js version. So no additions from my side.

@beatrycze-volk
Copy link
Contributor

@stweil and @sebastian-meyer thank you for solving this problem :)

@beatrycze-volk beatrycze-volk merged commit a64f42c into master Jul 29, 2024
7 checks passed
@sebastian-meyer sebastian-meyer deleted the update-packages branch July 29, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ maintenance A task to keep the code up-to-date and manageable.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants