This repository has been archived by the owner on Feb 19, 2022. It is now read-only.
feat: expandable options #308
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotSugden
force-pushed
the
feat/better-game-options
branch
from
9171302
to
cf89422
Compare
NotSugden
force-pushed
the
feat/better-game-options
branch
from
ae8be63
to
f4eb61b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed how the options work to only show an option if it actually has any effect, this makes scrolling through options alot easier as there are less to go through, they are also grouped better IMO
This PR also removes the pressing tab to view more options, that was kinda useless and annoying for most people
I'm not sure on only showing options like "mayor anonymous votes" or "sheriff kills x" if anon votes/x role is enabled respectively, just need feedback on this one