Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add runnable Example usage of Go bindings #67

Merged
merged 2 commits into from
Apr 4, 2022
Merged

Add runnable Example usage of Go bindings #67

merged 2 commits into from
Apr 4, 2022

Conversation

adonovan
Copy link
Contributor

@adonovan adonovan commented Mar 24, 2022 •
edited
Loading

Also:

  • update the Go TS grammar to master which includes recent (untagged) fixes for field/param names. (Is this wise?)
  • point out a bug in the recently added Node.FieldNameForChild method due to a bug in the underlying C library.
  • update README.

@adonovan
Copy link
Contributor Author

Hi @smacker, friendly ping...

smacker
smacker reviewed Mar 31, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@smacker
Copy link
Owner

smacker commented Mar 31, 2022

Thanks. It would be better to tag a new version of go grammar of course and use it here. But we can keep master temporarily.

@smacker smacker merged commit d5f0a70 into smacker:master Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smacker smacker smacker left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adonovan @smacker