Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ESCAPES flag to expression parser rules #747

Closed
wants to merge 1 commit into from
Closed

Add ESCAPES flag to expression parser rules #747

wants to merge 1 commit into from

Conversation

dmlloyd
Copy link
Contributor

@dmlloyd dmlloyd commented May 3, 2022

Fixes #746. If it works.

@dmlloyd
Copy link
Contributor Author

dmlloyd commented May 3, 2022

Interesting; this cause a failure because e.g. C:\foo\bar will not properly parse anymore. Unfixable problem? 🤷🏻‍♂️

@dmlloyd
Copy link
Contributor Author

dmlloyd commented May 3, 2022

@radcortez WDYT?

@radcortez
Copy link
Member

@radcortez WDYT?

Yes. I know what the issue is. Let me comment on the original one. You are going to love this :)

@radcortez radcortez mentioned this pull request May 3, 2022
Open
@dmlloyd dmlloyd closed this Jul 28, 2022
@dmlloyd dmlloyd deleted the esc branch July 28, 2022 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Escaping backslash does not work in front of replacement expression
2 participants
@dmlloyd @radcortez