Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If JWK is used to sign/encrypt JWT then use its kid and alg properties if they have not already been set #321

Closed
sberyozkin opened this issue Oct 15, 2020 · 3 comments · Fixed by #455
Closed

If JWK is used to sign/encrypt JWT then use its kid and alg properties if they have not already been set #321

sberyozkin opened this issue Oct 15, 2020 · 3 comments · Fixed by #455
Assignees
@sberyozkin
Milestone
3.1.1

Comments

@sberyozkin
Copy link
Contributor

No description provided.

@sberyozkin sberyozkin added this to the 2.3.2 milestone Oct 15, 2020
@sberyozkin sberyozkin mentioned this issue Nov 23, 2020
Merged
@sberyozkin sberyozkin removed this from the 2.3.2 milestone Nov 25, 2020
@sberyozkin
Copy link
Contributor Author

I've spent quite a bit of time on it, and had a fix, but then realized them same should apply to the algorithm property which JWK is expected to contain so I've decided not to rush with this trying to fix this issue for 2.4.0

@sberyozkin sberyozkin changed the title Use JWK kid when generating the tokens if no kid is already set If a single JWK is used to build JWT then use its kid and alg properties if they have not already been set Nov 25, 2020
@sberyozkin sberyozkin changed the title If a single JWK is used to build JWT then use its kid and alg properties if they have not already been set If JWK is used to sign/encrypt JWT then use its kid and alg properties if they have not already been set Apr 27, 2021
@sberyozkin
Copy link
Contributor Author

It should work with a single JWK - when both kid and alg (and encAlg for encryption) are collected from JWK - and with a multi-key JWK set - where kid is already known but alg/encAlg - may not yet

@sberyozkin sberyozkin self-assigned this Apr 27, 2021
@sberyozkin sberyozkin added this to the 3.1.1 milestone Apr 27, 2021
@sberyozkin
Copy link
Contributor Author

I'll try to fix this issue asap and release 3.1.1 (after updating the forum)

@sberyozkin sberyozkin mentioned this issue Apr 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sberyozkin sberyozkin

Labels
None yet
Projects
None yet
Milestone
3.1.1
Development

Successfully merging a pull request may close this issue.

Use JWK 'alg' and 'kid' when creating JWT if these headers are not set
1 participant
@sberyozkin