Split the implementation module into common, jwt-auth, jwt-build #331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply splits the current
implementation
module as per the smallry forum discussion, 3 modules are introduced:common
(smallrye-jwt-common
artifact id) module: whereKeyUtils
andResourceUtils
utility code has been moved tojwt-build
(smallrye-jwt-build
artifact id) module: where the JWT build related code has been moved tojwt-auth
module: the currentimplementation
module - except that the utility and build code is now coming fromsmallrye-jwt-common
andsmallrye-jwt-build
; I think we can drop thesmallrye-jwt-build
dependency for3.0.0
and let users who need it include it.KeyUtils
andResourceUtils
are inio.smallrye.jwt
package on master and inio.smallrye.jwt.util
package incommon
so I've kept the original classes injwt-auth
for now but deprecated them and updated to delegate to theircommon
friends. Thesejwt-auth
deprecated classes can be dropped in3.0.0
This is really it - plus some minor dependency clean-up made possible by this split.
After this PR is reviewed/merged I will follow up with 2 small fixes (#327, #321) and release
2.4.0