Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the implementation module into common, jwt-auth, jwt-build #331

Merged
merged 1 commit into from
Nov 24, 2020
Merged

Split the implementation module into common, jwt-auth, jwt-build #331

merged 1 commit into from
Nov 24, 2020

Conversation

sberyozkin
Copy link
Contributor

This PR simply splits the current implementation module as per the smallry forum discussion, 3 modules are introduced:

  • common (smallrye-jwt-common artifact id) module: where KeyUtils and ResourceUtils utility code has been moved to

  • jwt-build (smallrye-jwt-build artifact id) module: where the JWT build related code has been moved to

  • jwt-auth module: the current implementation module - except that the utility and build code is now coming from smallrye-jwt-commonand smallrye-jwt-build; I think we can drop the smallrye-jwt-build dependency for 3.0.0 and let users who need it include it.

  • KeyUtils and ResourceUtils are in io.smallrye.jwt package on master and in io.smallrye.jwt.util package in common so I've kept the original classes in jwt-auth for now but deprecated them and updated to delegate to their common friends. These jwt-auth deprecated classes can be dropped in 3.0.0

This is really it - plus some minor dependency clean-up made possible by this split.

After this PR is reviewed/merged I will follow up with 2 small fixes (#327, #321) and release 2.4.0

@sberyozkin sberyozkin added this to the 2.3.2 milestone Nov 23, 2020
Copy link
Member

@MikeEdgar MikeEdgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I didn't notice anything outside the described changes.

@radcortez
Copy link
Member

LGTM

@sberyozkin
Copy link
Contributor Author

@MikeEdgar @radcortez thanks, that should improve the modularization picture; for 3.0.0 I'll propose adding jwt-jaxrs and move the jaxrs specific code into it - right now, for example, in Quarkus we do not use the JAX-RS classes

@sberyozkin sberyozkin merged commit 12d97c3 into smallrye:master Nov 24, 2020
@sberyozkin sberyozkin deleted the jwt_build_module branch November 24, 2020 10:59
@sberyozkin
Copy link
Contributor Author

@MikeEdgar by the way, I meant to invite you to MP JWT gitter channel but ended up adding you, I thought it would send an invitation but looks like you are already in that room :-), sorry about me somehow skipping the invitation step; please don't hesitate to pause the memebership :-) of that room/channel if it becomes too noisy - don't think it will be noisy there though... thanks

@MikeEdgar
Copy link
Member

@sberyozkin - no problem. I realize now that I have not been getting notifications for that particular channel. I'll need to look into that :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants