Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UUID for the 'jti' claim, and update ResourceUtils to have a separate InputStream utility #349

Merged
merged 1 commit into from
Dec 13, 2020

Conversation

sberyozkin
Copy link
Contributor

Fixes #344

Also, minor refactoring of ResourceUtils to be able to use the utility code which gets the stream only, without converting it to String, realized it can be handy while I was coding some KeyStore.load

radcortez
radcortez previously approved these changes Dec 11, 2020
Copy link
Member

@radcortez radcortez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had some issues in SR Config and Quarkus with InputStream locking the jar. I'm not sure if this is the case, but I'm going to add a runner for Windows here so we can test for that issue as well.

@radcortez
Copy link
Member

BTW, before we merge something we should decide if we want to merge the mpjwt12 branch to master?

@sberyozkin
Copy link
Contributor Author

@radcortez Sure, I'm just opening the PRs today, but won't merge them before next week, I was thinking getting these PRs into 3.0.0.RC2 and do 2.4.1 as well early next week, we probably want to keep the master branch on 2.4.x untill we get the final 3.0.0 release ?
The 3 PRs I've opened are isolated to the builder API

@radcortez
Copy link
Member

Sounds good.

MikeEdgar
MikeEdgar previously approved these changes Dec 11, 2020
@sberyozkin sberyozkin dismissed stale reviews from MikeEdgar and radcortez via 3d5a4c5 December 13, 2020 21:52
@sberyozkin
Copy link
Contributor Author

@radcortez @MikeEdgar thanks I've just rebased this branch so if it goes green then I'll merge

@sberyozkin sberyozkin merged commit 65e65d7 into smallrye:master Dec 13, 2020
@sberyozkin sberyozkin deleted the jti_uuid branch December 13, 2020 21:56
@sberyozkin sberyozkin added this to the 2.4.1 milestone Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use a crypto-strong method for generating jti
3 participants