Enforce types of the directly supported claims when they are set as Objects #403
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #391
I've been thinking for a while what exactly would be the right course of action when someone types
.claim("sub", 1)
and decided that instead of silently converting to String and causing some potentially difficult to diagnose problems it would be better to enforce the correct types for only those claims which are well-known (ex JWT and Mp JWT specs) but more importantly those which are directly (have the dedicated setters) supported by this API - this will also ensure the consistent handling of such claims, whether they set in a typed way or as Objects.A few simple claims must be Strings,
aud
orgroups
- Strings or Collections of Strings,iat
andexp
-long
orInstant
.Also improved the documentation. And added
claim
setters acceptingClaims
as a claim name