Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smallrye.jwt.new-token.override-matching-claims property #431

Merged
merged 2 commits into from
Mar 1, 2021
Merged

Add smallrye.jwt.new-token.override-matching-claims property #431

merged 2 commits into from
Mar 1, 2021

Conversation

sberyozkin
Copy link
Contributor

@sberyozkin sberyozkin commented Feb 26, 2021

Fixes #420

This PR supports making the new-token.issuer and new-token.audience override the existing claims, such that, for example, in quarkus-oidc-token-propagation I can code:

@Inject JsonWebToken jwt;

String newJwt = Jwt.claims(jwt).sign();

and doc that the users - if they need this feature, should only configure the new signing key, and/or issuer and audience
etc.

Totally isolated to jwt-build

Copy link
Member

@MikeEdgar MikeEdgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sberyozkin
Copy link
Contributor Author

@MikeEdgar thanks, I think a single approval is enough for this update, CC @radcortez Roberto - I'll CC you in my Quarkus PR :-)

@sberyozkin
Copy link
Contributor Author

Just updated the branch

@sberyozkin sberyozkin merged commit dcff2aa into smallrye:master Mar 1, 2021
@sberyozkin sberyozkin deleted the jwt_build_new_token_override_claims branch March 1, 2021 15:47
sberyozkin added a commit that referenced this pull request Mar 3, 2021
* Bump smallrye-parent from 25 to 26 (#430)

Bumps [smallrye-parent](https://github.com/smallrye/smallrye-parent) from 25 to 26.
- [Release notes](https://github.com/smallrye/smallrye-parent/releases)
- [Commits](https://github.com/smallrye/smallrye-parent/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* Add smallrye.jwt.new-token.override-matching-claims property (#431)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the order in which JWT build configured claim values are applied configurable
2 participants