Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EdDSA to KeyUtils.keyFactoryAlgorithm() #789

Merged
merged 1 commit into from
May 3, 2024

Conversation

Eng-Fouad
Copy link
Contributor

Fixes #788

@sberyozkin
Copy link
Contributor

Thanks @Eng-Fouad, Can you give me a favor and start growing this test, https://github.com/smallrye/smallrye-jwt/blob/main/implementation/common/src/test/java/io/smallrye/jwt/util/KeyUtilsTest.java ?
Or maybe it is simpler to add a new test for the JWT token generation, copy and paste
https://github.com/smallrye/smallrye-jwt/blob/main/implementation/jwt-build/src/test/java/io/smallrye/jwt/build/JwtSignTest.java#L668

and have the key read from the PEM file ?

@Eng-Fouad Eng-Fouad force-pushed the #788 branch 2 times, most recently from 3593627 to 07595ff Compare May 2, 2024 12:52
@Eng-Fouad
Copy link
Contributor Author

Thanks @Eng-Fouad, Can you give me a favor and start growing this test, https://github.com/smallrye/smallrye-jwt/blob/main/implementation/common/src/test/java/io/smallrye/jwt/util/KeyUtilsTest.java ? Or maybe it is simpler to add a new test for the JWT token generation, copy and paste https://github.com/smallrye/smallrye-jwt/blob/main/implementation/jwt-build/src/test/java/io/smallrye/jwt/build/JwtSignTest.java#L668

and have the key read from the PEM file ?

Added few tests to KeyUtilsTest.

sberyozkin
sberyozkin previously approved these changes May 2, 2024
@sberyozkin
Copy link
Contributor

Thanks @Eng-Fouad They looks good, a minor suggestion to check that it is indeed the right classes that are produced. The main reason I've asked, is that I'm surprised with a 255 key size parameter

@sberyozkin sberyozkin merged commit 7f54faf into smallrye:main May 3, 2024
7 checks passed
@Eng-Fouad Eng-Fouad deleted the #788 branch May 3, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support EdDSA in KeyUtils.keyFactoryAlgorithm()
2 participants