Add messaging.consumer_id to span attribute for Kafka Consumer
#1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I assume this is related to open-telemetry/opentelemetry-specification#1810 ? Would be good to have it in a comment. As for AMQP, I don't know what AMQP concept would be a good fit. Perhaps the container ID, but it seems we set that to |
|
One thing we could add relatively easily for AMQP is a correlation ID, though :-) |
Ladicek
approved these changes
Jul 28, 2021
|
Yes, that's the spec change to add I thought there was an AMQP Client Id, but maybe I was wrong |
cescoffier
approved these changes
Aug 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to do the same for AMQP, but I couldn't find where I can get the Client ID from.
If someone knows, I can add to this PR