-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DNS service discovery #333
Conversation
service-discovery/dns/src/main/java/io/smallrye/stork/servicediscovery/dns/DnsMetadataKey.java
Outdated
Show resolved
Hide resolved
service-discovery/dns/src/main/java/io/smallrye/stork/servicediscovery/dns/DnsMetadataKey.java
Outdated
Show resolved
Hide resolved
...ry/dns/src/main/java/io/smallrye/stork/servicediscovery/dns/DnsServiceDiscoveryProvider.java
Outdated
Show resolved
Hide resolved
after a bit of thought I started wondering if going purely with UDP to talk with the DNS server is not a better option. |
Isn't DNS over UDP still a bit young? |
From what I read while working on this, DNS is primarily over UDP, with fallback to TCP |
Even on cloud providers? That's my concern. On the Cloud, UDP is not working great (most of the time) |
Good point, I'll convert this PR to draft then, I think the vertx resolver that I'm using by default does UDP. |
...-discovery/dns/src/main/java/io/smallrye/stork/servicediscovery/dns/DnsServiceDiscovery.java
Outdated
Show resolved
Hide resolved
...-discovery/dns/src/main/java/io/smallrye/stork/servicediscovery/dns/DnsServiceDiscovery.java
Outdated
Show resolved
Hide resolved
cd9375b
to
d580544
Compare
core/src/main/java/io/smallrye/stork/impl/CachingServiceDiscovery.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/smallrye/stork/utils/StorkAddressUtils.java
Outdated
Show resolved
Hide resolved
d580544
to
90b5d63
Compare
90b5d63
to
2d378c7
Compare
fixes #86
refs quarkusio/quarkus#26409