Add permanent identifier in the CreateAttestation response #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds an optional permanent identifier in the response of CreateAttestation request. In the YubiKey KMS the permanent identifier is the serial number present in the attestation certificate.
hslatman
reviewed
Mar 24, 2023
There was a problem hiding this comment.
Looks OK for the most part. Only reserve I have is if this should be called PermanentIdentifier, or something slightly more generic? While it's certainly used like a PermanentIdentifier would be used, this isn't currently coming from an actual PermanentIdentifier SAN, nor do we encode the Assigner with it (although the Issuer of the attestation cert can be used for that in lieu of the Assigner). It's a great name for it is and does, though. Some alternatives would be PersistentIdentifier and DurableIdentifier, but I still like PermanentIdentifier better. Identifier feels too generic and doesn't make clear that it can't/won't change, so also not great.
Co-authored-by: Herman Slatman <hslatman@users.noreply.github.com>
hslatman
approved these changes
Mar 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an optional permanent identifier in the CreateAttestation response. In the YubiKey KMS, the permanent identifier is the serial number in the attestation certificate.
This PR also files all linter errors.