Add support for creating attestation object #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attestation objects can be used to resolve ACME device-attest-01 challenges.
hslatman
reviewed
Feb 6, 2023
cmd/attest.go
Outdated
Comment on lines
49
to
53
| An attestation object can be used to resolve an ACME device-attest-01 challenge. | ||
| To pass this challenge the client needs to show prove of possession of a private | ||
| key by signing the ACME key authorization, the format is defined by RFC 8555 as | ||
| a string that concatenates the token for the challenge with a key fingerprint | ||
| separated by a "." character: |
There was a problem hiding this comment.
Suggested change
| An attestation object can be used to resolve an ACME device-attest-01 challenge. | |
| To pass this challenge the client needs to show prove of possession of a private | |
| key by signing the ACME key authorization, the format is defined by RFC 8555 as | |
| a string that concatenates the token for the challenge with a key fingerprint | |
| separated by a "." character: | |
| An attestation object can be used to resolve an ACME device-attest-01 challenge. | |
| To pass this challenge, the client needs proof possession of a private | |
| key by signing the ACME key authorization. The format is defined in RFC 8555 as | |
| a string that concatenates the challenge token with the ACME account key fingerprint | |
| separated by a "." character: |
|
I did approve it, but I think the command may be doing too many different things; may be too smart with just flags. More explicit might be better. Don't have better suggestions at the moment, though. Given that the plugin is still considered beta, I think we're good if we need to break the command later, so let's keep it like this for now? |
pizzasaurusrex
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support to creating attestation objects, this can be used to resolve ACME device-attest-01 challenges.