Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add example using pin-source method #95

Merged
merged 1 commit into from
Sep 7, 2023
Merged

doc: add example using pin-source method #95

merged 1 commit into from
Sep 7, 2023

Conversation

111a5ab1
Copy link
Contributor

@111a5ab1 111a5ab1 commented Sep 7, 2023

Name of feature:

Add example of using pin-source method to main README.md

Pain or issue this feature alleviates:

Usage examples in the README.md all use pin-value, giving the impression the PIN must be passed in insecurely via command-line.

There is a single example usage of pin-source in key.go, but this is easily missed.

This pull request changes the first two usage examples to use the pin-source method, to better call out this more secure method of providing the pin.

Supporting links/other PRs/issues:

@111a5ab1 111a5ab1 requested review from maraino and a team as code owners September 7, 2023 13:54
@CLAassistant
Copy link

CLAassistant commented Sep 7, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@maraino maraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @111a5ab1

@maraino maraino merged commit b90a457 into smallstep:main Sep 7, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc: add example using pin-source method
3 participants