Fix error when Font aren't available #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k00ni
requested changes
Aug 25, 2020
|
I'll try but none of the |
k00ni
approved these changes
Aug 31, 2020
This can happen (like in many places of `Page.php`) when the retrieved element is missing (and the instance if `ElementMissing`. In that case, we just return an empty array (the default value).
j0k3r
force-pushed
the
fix/font-elementmissing
branch
from
84fb055 to
cc4c77f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can happen (like in many places of
Page.php) when the retrieved element is missing (and the instance ifElementMissing. In that case, we just return an empty array (the default value).Fix #321