Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate cmake functions and macros #180

Closed
smanders opened this issue Apr 4, 2018 · 1 comment
Closed

migrate cmake functions and macros #180

smanders opened this issue Apr 4, 2018 · 1 comment
Assignees
@smanders
Labels
enhancement
Milestone
18.04.1

Comments

@smanders
Copy link
Owner

smanders commented Apr 4, 2018

there are some cmake functions and macros that we've had in a shared submodule that should be migrated to externpro -- we are moving in a direction where we don't want projects to require this shared submodule (especially just for the cmake)
@smanders smanders added this to the current milestone Apr 4, 2018
@smanders smanders self-assigned this Apr 4, 2018
@smanders smanders mentioned this issue Apr 4, 2018
Closed
53 tasks
smanders pushed a commit that referenced this issue Apr 5, 2018
copy of cmake from VantageShared
8d5705e 
* sdClassifiedRepo (with some details omitted) function
* classified_src, classified_exclusive_src macros
* sdSetFlags macro

see issue #180
smanders pushed a commit that referenced this issue Apr 5, 2018
break-up sdSetFlags
27fac24 
* xpSetFlags, xpSetUnitTestTools as public interfaces (to be called by outside cmake)
* xpSetMsvcFlags, xpSetGccFlags for compiler-specific flags

see issue #180
smanders pushed a commit that referenced this issue Apr 5, 2018
remove compiler checks inside xpSetMsvcFlags, xpSetGccFlags
b319ff7 
see issue #180
smanders pushed a commit that referenced this issue Apr 5, 2018
change cmake options prefix from SD_ to XP_
c3a4d83 
see issue #180
smanders pushed a commit that referenced this issue Apr 5, 2018
remove SD_USE_ASAN definition
488230f 
* code that was using this has been removed
* Avoid abort in plugin unit tests when running under ASan.
  * https://isrhub.usurf.usu.edu/petemace/VantageShared/commit/38bd94bb3d52567956dde1a3886225bab0a75537

see issue #180
smanders pushed a commit that referenced this issue Apr 5, 2018
XP_CMAKE_REPO_INSYNC option turned ON
270e1e2 
* moved from Shared/make/toplevel.cmake

see issue #180
smanders pushed a commit that referenced this issue Apr 5, 2018
_WIN32_WINNT set to 0x0601 (Windows 7)
ce57650 
* new library (web socket Sdws) uses boost asio
* won't require BOOST_ASIO_ENABLE_CANCELIO definition if we move this to at least 0x0600

see issue #180
smanders pushed a commit that referenced this issue Apr 5, 2018
rename, enhance classified repo cmake
e542f1a 
* sdClassifiedRepo renamed to xpClassifiedRepo and uses cmake_parse_arguments
* xpClassifiedRepo sets XP_CLAS_REPO with PARENT_SCOPE
  * makes this cmake variable visible to calling cmake and subdirectories below calling cmake
  * which makes cmake variable CLASSIFIED_BUILD kind of redundant and unnecessary, so removed
  * CLASS_BUILD definition removed (unnecessary and avoids a global definition)
  * if code needs a definition (CLASS_BUILD) it can do so itself where it needs it
    if(DEFINED XP_CLAS_REPO)
      add_definition(-DCLASS_BUILD)
    endif()
  * used by xpClassifiedSrc and xpClassifiedSrcExc functions
* classified_src cmake macro renamed to xpClassifiedSrc and made a cmake function
* classified_exclusive_src cmake macro renamed to xpClassifiedSrcExc and made a cmake function

see issue #180
smanders pushed a commit that referenced this issue Apr 5, 2018
new xpGenerateRevision cmake function
9190a75 
* uses cmake_parse_arguments to set SOURCE_DIR and RELEASE_BRANCH (both optional)
  * default values SOURCE_DIR: ${CMAKE_SOURCE_DIR} and RELEASE_BRANCH: master
* simplifies and clarifies generating a Revision.hpp with revision.cmake

see issue #180
smanders pushed a commit that referenced this issue Apr 9, 2018
rename xpSetFlags<Compiler> macros
ab935a9 
* was xpSetMsvcFlags and xpSetGccFlags - now xpSetFlagsMsvc and xpSetFlagsGcc
* easier to search for xpSetFlags and see all the variations

issue #180
smanders pushed a commit that referenced this issue Apr 9, 2018
enhanced cmscopyfilemd5.cmake
3a457e0 
* adds multiple tries at making destination directory
* remove smbget --dots and --quiet options and commented-out code
* https://isrhub.usurf.usu.edu/petemace/VantageMedia/commit/505f7f360c44d21da676669274ce412e10208418
  * see commit comment: "the new cpfilemd5.cmake is a modified copy of externpro's cmscopyfilemd5.cmake and the changes could go back there in the next release of externpro"

issue #180
smanders pushed a commit that referenced this issue Apr 10, 2018
remove global definition of CURL_STATICLIB on MSW
d294e53 
* makes xpSetFlags or xpSetFlagsMsvc more general and reusable (not VANTAGE specific)
* moved comment from global definition to the curl use script

issue #180
smanders pushed a commit that referenced this issue Apr 25, 2018
create xpSetFlagsGccDebug macro
c8d271e 
* cmake copied from palam, then modified
* existing XP_USE_ASAN XP_COVERAGE cmake options moved into new xpSetFlagsGccDebug
* 'make coverage' custom target to generate a coverage report
* extensible XP_COVERAGE_RM cmake variable so projects can add to the list of directories to remove from report
* CMAKE_CXX_FLAGS_DEBUG was always -O0 before
  * now -O0 if XP_COVERAGE is ON
  * otherwise -Og

issue #180
smanders pushed a commit that referenced this issue Apr 26, 2018
enhance xpSetFlagsGccDebug macro
6d38639 
* allow XP_USE_ASAN XP_COVERAGE cmake options to be set before macro called, modifying default
* correctly find asan (check compiler flag requires asan library)
* coverage target and search for lcov/genhtml only if XP_COVERAGE and build type is Debug

issue #180
@smanders
Copy link
Owner Author

completed with commits referenced above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smanders smanders

Labels
enhancement
Projects
None yet
Milestone
18.04.1
Development

No branches or pull requests
1 participant
@smanders