Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake AUTHOR_WARNING if linux distribution doesn't match #220

Closed
smanders opened this issue Oct 24, 2018 · 3 comments
Closed

cmake AUTHOR_WARNING if linux distribution doesn't match #220

smanders opened this issue Oct 24, 2018 · 3 comments
Assignees
Milestone

Comments

@smanders
Copy link
Owner

there have been issues when a developer on a given linux distribution uses an externpro built on a different distribution (or a different version - for example Ubuntu 16.04 vs 18.04)

record lsb_release -d in the XP_INFOFILE (.txt file at the root of the externpro installation) and then add some cmake to the find script to output a message(AUTHOR_WARNING if the distributions don't match

@smanders smanders added this to the current milestone Oct 24, 2018
@smanders smanders self-assigned this Oct 24, 2018
smanders pushed a commit that referenced this issue Oct 24, 2018
smanders pushed a commit that referenced this issue Oct 24, 2018
* for easier searching to verify distributions match
* issue #220
@smanders smanders mentioned this issue Oct 25, 2018
53 tasks
@smanders
Copy link
Owner Author

completed with commits to dev branch referenced above

@smanders
Copy link
Owner Author

just a note about a thought that I had related to this issue... (future enhancement)

  • if we wanted to record something similar to lsb_release -d which is linux-specific, on Windows we could use systeminfo and record the OS Name: and/or OS Version: lines
  • systeminfo gives results back in the terminal, which we could parse out... winver pops up a GUI

@smanders
Copy link
Owner Author

this warning will serve as a reminder that building externpro and using externpro on two different distributions is unsupported - and the issue in #210 would have been easier to spot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant