Merge pull request #58 from GenevieveBuckley/reraise-error-messages

Re-raise errors for better ExtensionError messages
smarie · Nov 21, 2023 · 35e7961 · 35e7961
2 parents d4c2d7f + c33ae78
commit 35e7961
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/docs/changelog.md b/docs/changelog.md
@@ -3,6 +3,7 @@
 ### 0.7.9 - (In Progress)
 
  - Swapped from deprecated `disutils.version` to `packaging.version`. PR [#79](https://github.com/smarie/mkdocs-gallery/pull/79) by [Samreay](https://github.com/Samreay)
+ - Re-raise errors for better ExtensionError messages, so users have full details about the original problem. PR [#58](https://github.com/smarie/mkdocs-gallery/pull/58) by [GenevieveBuckley](https://github.com/GenevieveBuckley)
 
 ### 0.7.8 - Bugfixes
 

diff --git a/src/mkdocs_gallery/gen_gallery.py b/src/mkdocs_gallery/gen_gallery.py
@@ -144,15 +144,15 @@ def load_base_conf(script: Path = None) -> Dict:
         spec = spec_from_file_location("__mkdocs_gallery_conf", script)
         foo = module_from_spec(spec)
         spec.loader.exec_module(foo)
-    except ImportError:
-        raise ExtensionError(f"Error importing base configuration from `base_conf_py` {script}")
+    except ImportError as err_msg:
+        raise ExtensionError(f"Error importing base configuration from `base_conf_py` {script}\n{err_msg}")
 
     try:
         return foo.conf
-    except AttributeError:
+    except AttributeError as err_msg:
         raise ExtensionError(
             f"Error loading base configuration from `base_conf_py` {script}, module does not contain "
-            f"a `conf` variable."
+            f"a `conf` variable.\n{err_msg}"
         )