-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add tests for type info #27
Conversation
Great @last-partizan , thanks so much for sticking to this ! I made a few comments, small details / maintainability topics mostly |
0eea523
to
cfff747
Compare
Huh, i've got somewhat distracted by Russians invading my country and forgot about this PR :) Now let's get to work! |
Thanks a lot @last-partizan for this great PR ! I have a few comments concerning the way pyright is installed, see details in the files diff. However otherwise it looks really good ! (I hope that you and your relatives are safe. Terrible times...) Note that I'll be away next week so sorry if there are delays in reviewing the next round. |
Everything ready! |
Thanks @last-partizan ! Sorry for the wait... (And on a side note I hope everything is ok with you and relatives wrt the war) |
Here I added tests using pyright and pytest plugin for snapshot testing syrupy. It allows us not to hardcode expected data in test, but to have it separated in snapshot files.
Those tests are running only on python 3.7+, other versions aren't supported, so I added
pytest.mark.skipif
, which could be removed after next major version and dropping everything below 3.7.Right now pyright is checking that there is no errors in unexpected places, and errors in expected places.