-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parametrize_with_cases can get argnames as list #132
Conversation
Codecov Report
@@ Coverage Diff @@
## master #132 +/- ##
==========================================
+ Coverage 90.96% 91.00% +0.04%
==========================================
Files 115 116 +1
Lines 4536 4558 +22
==========================================
+ Hits 4126 4148 +22
Misses 410 410
Continue to review full report at Codecov.
|
Wasn't sure where to add new tests to check the new ability. please let me know where the right place is, and I'll add the missing test. |
Indeed, thanks @saroad2 ! From the Can you change your code so that
Also can you please create a test file (tests/cases/doc/test_parametrize_alt.py) containing one test with a list and one test with a tuple ? Thanks ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me (I just made a small fix to the second error message).
thanks @saroad2 ! I'll make the release tomorrow
Fix #133
At the moment, the "argnames" parameter of
parametrize_with_cases
can only get strings as input, but it should except list of strings as well.