Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximum number of reassigns #189

Closed
sobolevn opened this issue May 14, 2019 · 3 comments · Fixed by #211
Closed

Maximum number of reassigns #189

sobolevn opened this issue May 14, 2019 · 3 comments · Fixed by #211

Comments

@sobolevn
Copy link
Contributor

When marge user creates a merge request and is assigned to merge it, infinite loop happens.

Снимок экрана 2019-05-14 в 16 00 05

Снимок экрана 2019-05-14 в 15 59 46

And there's no stopping mechanism. I suggest to add something like --max-reassigns option to stop it.

Or to check if future assignee and author is the same user. It might be easier.

@aschmolck
Copy link
Contributor

I think your suggestion of marge-bot not unassigning itself just to re-assigning to itself is the right one, I'd be happy to accept a PR to that effect.

This is just a minor issue, because it shouldn't happen outside people testing their marge-bot setup, but I agree it would nonetheless good to fix.

@micheelengronne
Copy link

Related #202

@micheelengronne
Copy link

MR #203

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants