Fix unassign when author is marge #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the docs: "Set to 0 or provide an empty value to unassign all assignees."[1] So setting to `None` seems like it would work, although in practice it doesn't. I've manually tested with `0` and it works fine. [1] https://docs.gitlab.com/ee/api/merge_requests.html#update-mr
|
The problem is that it remove the PR from any assignee. Making it lost in the void :) |
|
I am working on a solution to avoid the flood that keeps assignees #210 I just have to figure out how to add an endpoint in the mock. |
|
@micheelengronne Removing the PR from any assignee (and maybe leaving a comment about user error) is the correct behaviour. Marge-bot is not meant to be the author of PRs, and although this should fail gracefully (maybe with an explanatory note), I'm not interested in code support beyond this, since it's nothing that can ever work particularly well in the first place. Having said that, if there is something that would be desirable for other reasons and helps this unsupported use case I might still consider merging it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the docs:
"Set to 0 or provide an empty value to unassign all assignees."[1]
So setting to
Noneseems like it would work, although in practice it doesn't.I've manually tested with
0and it works fine.[1] https://docs.gitlab.com/ee/api/merge_requests.html#update-mr
Fixes: #189