Check MR is mergeable before accepting MR #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's useful to check that we are still able to merge the MR after it has finished CI. Whilst we can check the error message afterwards, these are not always clearer and we'd essentially be doing the same checks as these anyway. As an extra advantage, we also refuse to merge if someone has since unassigned from Marge (something that people tend to do without realising it has no effect after Marge has run it's preflight checks).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's useful to check that we are still able to merge the MR after it has
finished CI. Whilst we can check the error message afterwards, these are
not always clearer and we'd essentially be doing the same checks as
these anyway.
As an extra advantage, we also refuse to merge if someone has since
unassigned from Marge (something that people tend to do without
realising it has no effect after Marge has run it's preflight checks).