Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve batching: allow batch MRs use merge commits #264

Merged
merged 14 commits into from
Oct 6, 2020

Conversation

tclh123
Copy link
Contributor

@tclh123 tclh123 commented Jul 28, 2020

Previously, we applies the commits in individual MRs to the batch MR linearly, so the commits will be rewritten and the commit sha will not be the same one passed CI, which is not good.

To make the commits be exactly the same in the individual MRs and the batch MR, I added an option to allow using merge commits in batch MRs. It acts as a helper commit in the temp branch (the batch branch) which won't affect the final merge method (we usually use the fast forwarding merge).
Besides, updating (rebase master and apply trailers) each MR before we create the batch MR to avoid rewrite commits after.

  • Add --use-merge-commit-batches option: Use merge commit when creating batches, so that the commits in the batch MR will be the same with in individual MRs.
  • Add --skip-ci-batches option: Skip CI when updating individual MRs when using batches. Since we have tested the batch MR, no need to run CI on individual MRs any more after we rewrite the commits.

Fixes #164 #252

Copy link

@bostik bostik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could fold this commit to its parent. It only adds noise to the commit history.

marge/app.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants