Get latest CI status of a commit filtered by branch #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamb
changed the title
Changes the CI status check to use the pipelines API, in order to filter status by ref (branch).
|
Looks good to me. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation fetches the latest CI status for a particular sha. While a relatively rare circumstance, it's possible that at the point Marge-bot picks up an MR, another developer may have branched from the same commit and pushed to the repository. This new pipeline would be detected by Marge-bot, which could then be cancelled, causing Marge-bot to drop the MR stating "CI cancelled", while the CI for the correct branch will have passed.
This MR changes the CI status check to use the pipelines API, in order to filter status by ref (branch).
Commit.fetch_by_id() is no longer used after this change, I wasn't entirely sure whether I should remove that as part of this, leave it for a follow-up, or for you to decide what to do with it.