Reduce memory usage and calculate statistics online/incrementally #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids keeping all data points in memory, and should not have any drawbacks for ReBench’s functionality. However, this also removes the scipy/numpy usage, and all mentioning of medians. For support of quartile/median reporting to codespeed, we’d need to keep the datapoints, at least temporarily. Though, I would really prefer to safe them all in codespeed. Signed-off-by: Stefan Marr <git@stefan-marr.de>
This avoids a second path over the data, and avoids keeping the data points around indefinitely. Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
This is an attempt to optimize, but I think it also makes the code less convoluted. Signed-off-by: Stefan Marr <git@stefan-marr.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way ReBench handles data.
It fixes #100.
The key idea is to avoid keeping all data points and measurements in memory.
This is achieved by calculating statistics incrementally.
One major change related to it is how we discard data for reruns, which is now fused with loading that data file. This may speedup data loading, too.
@daumayr this should hopefully fix your issue.