Fix how settings are inherited, strictly follow documentation #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- mode useful assert method to ReBenchTestCase Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
- this instantiates executors in the context of the experiments, and then creates them for the benchmark suites - use executor details in benchmarks suite compilation explicitly Signed-off-by: Stefan Marr <git@stefan-marr.de>
smarr
force-pushed
the
issue-112-invocations-ignored
branch
from
a0eb439
to
3c01ce5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #112.
Simplify the implementation, and remove a strange deviation from the simple case.
We kept the executor objects globally, which meant they were not configured in the context of an experiment.
This change fixes this by not keeping them anymore, but instantiate them as all other settings.