-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Robustify Process handling and extend a bit #127
Open
krono
wants to merge
9
commits into
smarr:master
Choose a base branch
from
krono:krono/process-robustness-expansion
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Oct 1, 2019
-
Python from 3.2 on support timeouts on subprocesses directly subprocess32 backports that to Python 2
Configuration menu - View commit details
-
Copy full SHA for ed23f59 - Browse repository at this point
Copy the full SHA ed23f59View commit details -
Code defaults via default parameters.
Easier to read. Also, `timeout=None` because that's what modern subprocess expects
Configuration menu - View commit details
-
Copy full SHA for 5ac081c - Browse repository at this point
Copy the full SHA 5ac081cView commit details -
Configuration menu - View commit details
-
Copy full SHA for d46f79c - Browse repository at this point
Copy the full SHA d46f79cView commit details -
Robustify process handling in presence of threads
There are many caveats, but at least Ctrl-C now works as expected.
Configuration menu - View commit details
-
Copy full SHA for 5ee64a0 - Browse repository at this point
Copy the full SHA 5ee64a0View commit details -
Isolate persistence writing to file to one thread
There were out-of-order writes to the persitence file when there were multiple threads. This confines file-writing to a dedicated thread that works a Queue.
Configuration menu - View commit details
-
Copy full SHA for 44fe332 - Browse repository at this point
Copy the full SHA 44fe332View commit details
Commits on Oct 3, 2019
-
Configuration menu - View commit details
-
Copy full SHA for cc6b5f2 - Browse repository at this point
Copy the full SHA cc6b5f2View commit details
Commits on Oct 7, 2019
-
Configuration menu - View commit details
-
Copy full SHA for f3012f1 - Browse repository at this point
Copy the full SHA f3012f1View commit details -
Add queue-based pulling parallel scheduler
The existing parallel scheduler behaves as is (With common behavior lifted to a new base clase). A new parallel scheulder maintains a work queue and the workers retrieve directly from there. a distinction is made for py2 vs py3, to make use of the built-in thread pool executor when possible. No new magic so far
Configuration menu - View commit details
-
Copy full SHA for 92e9701 - Browse repository at this point
Copy the full SHA 92e9701View commit details -
Configuration menu - View commit details
-
Copy full SHA for d404b8e - Browse repository at this point
Copy the full SHA d404b8eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.