Enable iterations, invocations, and warmup settings to be marked as important #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Marr <git@stefan-marr.de>
…p by appending exclamation mark This means we don't have proper integer validation in the schema anymore. Signed-off-by: Stefan Marr <git@stefan-marr.de>
smarr
force-pushed
the
important-settings
branch
from
2ed8f97
to
bbca98f
Compare
This was referenced Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined in #169, the composition strategy of experiments is not ideal for all use cases. To make it possible to set different invocation/iteration/warmup settings for profiling, this PR adds the option to use the
!(exclamation mark) to mark a setting as important. This will then override settings with higher priority.If there are multiple settings marked as important, the normal priority order applies.
This adds support to mark values for the following settings as important: