Include CSV header in data files #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a test for this in https://github.com/smarr/ReBench/blob/master/rebench/tests/persistency_test.py? It has some examples. Currently, it doesn't really access the file directly to check that the data is in there, but only loads the data. For our purposes, it would be good read the file just directly in the test and check that it contains the expected lines. The file is configured for instance here: https://github.com/smarr/ReBench/blob/master/rebench/tests/persistency_test.py#L67-L68 And the name of the file is accessible via |
smarr
requested changes
Jul 10, 2023
smarr
requested changes
Jul 12, 2023
naomiGrew
force-pushed
the
Scv-header
branch
3 times, most recently
from
d3bf3fb
to
64eec7a
Compare
smarr
reviewed
Jul 12, 2023
create csv headers Remove trailing whitespace add test to check if shebang line and csv header are in file and are correct add the csv header in same place as shebang line implement get column headers fetch column headers for measurement get column headers for run id fix trailing whitespace remove trailing whitespace fix trailing whitespace fix trailing whitespace fixing whitespace fix indentation add line to disable pylint error and fix typo fix typo simplify test_check_file_lines to use deadlines() change assertEquals to assertEqual add extraArgs to csv header remove trailing whitespace add check for data values for every header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #188