Fast abort of benchmarks when same executable is missing #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarr
requested changes
Jul 17, 2023
naomiGrew
force-pushed
the
missingBinary
branch
2 times, most recently
from
d6c9d8e
to
8c493e2
Compare
smarr
requested changes
Jul 18, 2023
naomiGrew
force-pushed
the
missingBinary
branch
3 times, most recently
from
2458acc
to
3879bae
Compare
smarr
requested changes
Jul 24, 2023
naomiGrew
force-pushed
the
missingBinary
branch
5 times, most recently
from
298d90a
to
14b3ea1
Compare
fix pylint issues return true false logic of completed_task create method to mark binary as missing give executor a binary missing attribute change logic of batch scheduler to consume first item in list add get_executor and is_binary_missing to run id
test all executors
- also mark it so that it isn’t considered a test
smarr
changed the title
|
Using the executor object to identify run ids that won't work is catching only a part of them. Thus, instead of checking the executor object, I am now checking the executable path/filename as part of the cmdline. This also makes sure we only match the same executables. The problem here is that we can use the various variables in the command line expansions also in the path or executor names. Thus, looking at the cmdline after expansion is better. |
…executable This avoids issues with the command line being created early for runId identity Need to sort the runs so that we have a deterministic order.
… path We support interpolation of variables in executer path and excutable name, this, need to use the rendered version. Executor objects may also be instantiated multiple times, which means we can’t really use identity. Change used vocabulary to remove binary, since we use executable in the config file.
smarr
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.