Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Python 3 and PyPy #65

Merged
merged 24 commits into from
May 31, 2018
Merged

Support Python 3 and PyPy #65

merged 24 commits into from
May 31, 2018

Conversation

smarr
Copy link
Owner

@smarr smarr commented May 31, 2018

This PR adapts ReBench to be compatible with Python 3.

With this change, we support and test now:

  • Python 2.7
  • Python 3.5

This includes CPython as well as PyPy.

@smarr smarr added the Feature label May 31, 2018
@smarr smarr self-assigned this May 31, 2018
@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 82.156% when pulling 87c2947 on python3 into 2bd94a3 on master.

@coveralls
Copy link

coveralls commented May 31, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 81.551% when pulling cb37047 on python3 into 2bd94a3 on master.

smarr added 23 commits May 31, 2018 18:33
@smarr
Added more Python version for testing on Travis
f40323d 
- simplify setup
- use build matrix

Signed-off-by: Stefan Marr <git@stefan-marr.de>
@smarr
[Python 3] Use find_packages
eed23c0 
Signed-off-by: Stefan Marr <git@stefan-marr.de>
@smarr
[Python 3] Use relative import
d5d8cba 
Signed-off-by: Stefan Marr <git@stefan-marr.de>
@smarr
[Python 3] Add parentheses to print function
3cf6d91 
Signed-off-by: Stefan Marr <git@stefan-marr.de>
@smarr
Prefer assertEqual
48cc48c 
Signed-off-by: Stefan Marr <git@stefan-marr.de>
@smarr
[Python 3] Fix except syntax
c258522 
Signed-off-by: Stefan Marr <git@stefan-marr.de>
@smarr
[Python 3] Use proper octal literal
3eb8c21 
Signed-off-by: Stefan Marr <git@stefan-marr.de>
@smarr
[Python 3] Use dual import for http support on Python 2 and 3
97bbcc4 
Signed-off-by: Stefan Marr <git@stefan-marr.de>
@smarr
[Python 3] Use open() instead of file()
4598bab 
Signed-off-by: Stefan Marr <git@stefan-marr.de>
@smarr
[Python 3] Decode data read from pipes as utf-8
d936a4c 
Signed-off-by: Stefan Marr <git@stefan-marr.de>
@smarr
[Python 3] Make sure index is not a float
9a8b4f5 
Signed-off-by: Stefan Marr <git@stefan-marr.de>
@smarr
[Python 3] Use isinstance() instead of type()
a1107b0 
Signed-off-by: Stefan Marr <git@stefan-marr.de>
@smarr
[Python 3] Convert dict values to list for iteration
22b777c 
Signed-off-by: Stefan Marr <git@stefan-marr.de>
@smarr
[Python 3] Need to import reduce
14b1764 
Signed-off-by: Stefan Marr <git@stefan-marr.de>
@smarr
[Python 3] Use iterator correctly
0f986d0 
Signed-off-by: Stefan Marr <git@stefan-marr.de>
@smarr
[Python 3] Use str() to get error message
9781c5c 
Signed-off-by: Stefan Marr <git@stefan-marr.de>
@smarr
[Python 3] Make Popen override Python 3 compatible
5e21754 
Signed-off-by: Stefan Marr <git@stefan-marr.de>
@smarr
Determine child process in a way that works on Linux and macOS
0a1e49a 
Signed-off-by: Stefan Marr <git@stefan-marr.de>
@smarr
For thread safety, synchronize setting/getting of process id
edd1a70 
Signed-off-by: Stefan Marr <git@stefan-marr.de>
@smarr
Whitespace
8b6858f 
Signed-off-by: Stefan Marr <git@stefan-marr.de>
@smarr
[Python 3] Adapt print of vm1 and vm2
ebf0a21 
Signed-off-by: Stefan Marr <git@stefan-marr.de>
@smarr
[Python 3] Convert range to list, seems preferred
2fe4927 
Signed-off-by: Stefan Marr <git@stefan-marr.de>
@smarr
Ignore race between process termination and kill
b1b61c3 
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Repository owner deleted a comment May 31, 2018
Repository owner deleted a comment May 31, 2018
@smarr
Added changelog entry
cb37047 
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Repository owner deleted a comment May 31, 2018
Repository owner deleted a comment May 31, 2018
@smarr smarr changed the title Support Python 3 Support Python 3 and PyPy May 31, 2018
@smarr smarr merged commit 20c27cb into master May 31, 2018
@smarr smarr deleted the python3 branch May 31, 2018 17:47
@smarr smarr added this to the v1.0 - Foundation milestone Jun 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@smarr smarr

Labels
Feature
Projects
None yet
Milestone
v1.0 - Foundation
Development

Successfully merging this pull request may close these issues.
2 participants
@smarr @coveralls