Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework configuration and use iteration/invocation #82

Merged
merged 14 commits into from
Jun 18, 2018

Commits on Jun 18, 2018

  1. Removing quick runs

    - will be replaced by an invocation/iteration override
    
    Signed-off-by: Stefan Marr <git@stefan-marr.de>
    smarr committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    4e1d5fb View commit details
    Browse the repository at this point in the history
  2. Remove statistics from schema

    These used to be abort conditions, but are long removed again.
    
    Signed-off-by: Stefan Marr <git@stefan-marr.de>
    smarr committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    b61caa1 View commit details
    Browse the repository at this point in the history
  3. Adapt schema to add iteration/invocation

    Signed-off-by: Stefan Marr <git@stefan-marr.de>
    smarr committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    e0499ef View commit details
    Browse the repository at this point in the history
  4. Rename max_runtime to max_invocation_time, min_runtime to min_iterati…

    …on_time
    
    Signed-off-by: Stefan Marr <git@stefan-marr.de>
    smarr committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    fab389b View commit details
    Browse the repository at this point in the history
  5. Remove fallback code for old config name

    Signed-off-by: Stefan Marr <git@stefan-marr.de>
    smarr committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    9dea46b View commit details
    Browse the repository at this point in the history
  6. Remove actions from schema

    We never really supported different actions beside benchmarking (profiling, …), and there are no current plans to do so.
    This can be easily achieved in other ways.
    For instance by defining a different VM that does profiling and uses a different gauge_adapter.
    
    Signed-off-by: Stefan Marr <git@stefan-marr.de>
    smarr committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    ba092f9 View commit details
    Browse the repository at this point in the history
  7. Make log message about skipped data points less ambiguous

    Signed-off-by: Stefan Marr <git@stefan-marr.de>
    smarr committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    d127f33 View commit details
    Browse the repository at this point in the history
  8. Make schema more self-consistent

    - remove number_of_data_points
      - it is completely replaced by iterations/invocations
    - move warmup into EXP_RUN_DETAILS
    - move execute_exclusively into EXP_RUN_DETAILS
    - add EXP_VARIABLES to benchmark_type_map elements, and move the whole thing to resolve forward dependency
    - make some more attributes required: gauge_adapter, command, benchmarks
    - rename `benchmark` to `suites`
    
    - add defaults
    - some defaults can’t be defined in the schema, because it would interfere with our desired semantics of combining settings
    - improve descriptions
    
    - adapt conf files accordingly
    
    Signed-off-by: Stefan Marr <git@stefan-marr.de>
    smarr committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    f7bdba1 View commit details
    Browse the repository at this point in the history
  9. Move load_config outside of Configurator

    - it is only loading and checking the validity of the configuration
    
    Signed-off-by: Stefan Marr <git@stefan-marr.de>
    smarr committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    43713c3 View commit details
    Browse the repository at this point in the history
  10. Move can_set_niceness outside of Configurator

    This should probably still into an OS-specific package, but currently, only care for Unix-like things anyway.
    
    Signed-off-by: Stefan Marr <git@stefan-marr.de>
    smarr committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    f4ecd20 View commit details
    Browse the repository at this point in the history
  11. Implement the interpretation of the new schema

    - make naming more consistent with high-level concepts: Benchmark instead of BenchmarkConfig
    
    Signed-off-by: Stefan Marr <git@stefan-marr.de>
    smarr committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    1cde86b View commit details
    Browse the repository at this point in the history
  12. Add data-file and build-log as command-line overrides

    This means, we have all top-level settings as overrides for the command line.
    
    Signed-off-by: Stefan Marr <git@stefan-marr.de>
    smarr committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    e6f40e6 View commit details
    Browse the repository at this point in the history
  13. Rename to termination_check module

    The runs concept is gone.
    
    Signed-off-by: Stefan Marr <git@stefan-marr.de>
    smarr committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    40e8841 View commit details
    Browse the repository at this point in the history
  14. Reorder properties go to the top

    Signed-off-by: Stefan Marr <git@stefan-marr.de>
    smarr committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    777ee88 View commit details
    Browse the repository at this point in the history