Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix replay test flakiness #268

Merged
merged 1 commit into from
Sep 3, 2018
Merged

Fix replay test flakiness #268

merged 1 commit into from
Sep 3, 2018

Conversation

daumayr
Copy link
Contributor

@daumayr daumayr commented Sep 3, 2018

Exit code was changed to 1 when there were some unprocessed but expected messages at termination.
Exit code no longer touched by message check, message reports only printed when exiting with codes other than 0.

Exit code was changed to 1 when there were some unprocessed but expected messages at termination.
@smarr smarr added this to the v0.7.0 milestone Sep 3, 2018
@smarr smarr self-assigned this Sep 3, 2018
Copy link
Owner

@smarr smarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

The code in replayCanProcess(.) looks a little ugly. Perhaps there is a simple method hiding somewhere to make it look nicer. I won't bother in this PR though.

Thanks.

@smarr smarr merged commit af2c447 into smarr:dev Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants