Added Support for ZHA connected Tuya 1201 / Moes Universal Remote #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Support for EXP34U338CW / YK-H/531E
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Support for EXP34U338CW / YK-H/531E
Hi,
This PR adds support for the "Tuya 1201", or "Moes Universal Remote" as the packaging on the device suggests. It might work on other devices, I have yet to test that since I don't have another Zigbee enabled IR device.
This will also require the non-upstream quirk from ZHA: zigpy/zha-device-handlers#2336
Though, this seems to be considered for upstream shortly.
I started doing this without realizing that #1178 and #1137 had already done the work. So our approaches might differ slightly..
in #1178 i saw some discussions regarding how
controller_datashould be set up. I did not really think so thoroughly through this, as I have no actual clue what I'm doing. Trying to find documentation on howhass.services.async_call()wasn't that successful so I just bruteforced my way through it, specially when trying to find how to programmatically handle the sending of the codes, as described in zigpy/zha-device-handlers#1687 (comment). But I did try it with 2 different Tuya devices (Different IEEE-identifiers) on 2 separate AC units and it worked. Though if you have multiple ZHA dongles in your homeassistant this might not work?So with that said, maybe the actual handling of ZHA devices could be ignored and this could only be a PR for the EXP34U338CW / YK-H/531E support, through however the project decides how to support ZHA devices.