Merge pull request #21 from smartadserver/default-startdelay

Handle specified midroll
smartadserver · Mar 25, 2024 · 70a4a89 · 70a4a89
2 parents f3c5ded + f4dd203
commit 70a4a89
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 6 deletions.
diff --git a/modules/smartadserverBidAdapter.js b/modules/smartadserverBidAdapter.js
@@ -134,12 +134,11 @@ export const spec = {
   getStartDelayForVideoBidRequest: function(videoMediaType, videoParams) {
     if (videoParams?.startDelay) {
       return videoParams.startDelay;
-    } else if (videoMediaType) {
-      switch (videoMediaType.startdelay) {
-        case -1:
-          return 2;
-        case -2:
-          return 3;
+    } else if (videoMediaType?.startdelay) {
+      if (videoMediaType.startdelay > 0 || videoMediaType.startdelay == -1) {
+        return 2;
+      } else if (videoMediaType.startdelay == -2) {
+        return 3;
       }
     }
     return 1; // SADR-5619

diff --git a/test/spec/modules/smartadserverBidAdapter_spec.js b/test/spec/modules/smartadserverBidAdapter_spec.js
@@ -1165,6 +1165,28 @@ describe('Smart bid adapter tests', function () {
       expect(requestContent).to.have.property('videoData');
       expect(requestContent.videoData).to.have.property('adBreak').and.to.equal(3);
     });
+
+    it('should return specified value of videoMediaType.startdelay', function () {
+      const request = spec.buildRequests([{
+        bidder: 'smartadserver',
+        mediaTypes: {
+          video: {
+            context: 'outstream',
+            playerSize: [[640, 480]],
+            startdelay: 60
+          }
+        },
+        params: {
+          siteId: 123,
+          pageId: 456,
+          formatId: 78
+        }
+      }]);
+
+      const requestContent = JSON.parse(request[0].data);
+      expect(requestContent).to.have.property('videoData');
+      expect(requestContent.videoData).to.have.property('adBreak').and.to.equal(2);
+    });
   });
 
   describe('External ids tests', function () {