fix: logging, workflow reference validation (#640)

smartcontractkit · Sep 26, 2024 · ba7692f · ba7692f
1 parent 094e8de
commit ba7692f
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 17 deletions.
diff --git a/.changeset/calm-timers-sleep.md b/.changeset/calm-timers-sleep.md
@@ -0,0 +1,5 @@
+---
+"gha-workflow-validator": patch
+---
+
+fix: proper logging during validation, fully skip validation of workflows
diff --git a/actions/gha-workflow-validator/dist/index.js b/actions/gha-workflow-validator/dist/index.js
@@ -24081,6 +24081,12 @@ async function validateActionReference(octokit, options, actionRef) {
   if (!actionRef) {
     return [];
   }
+  if (actionRef.isWorkflowFile) {
+    core3.debug(
+      `Skipping validation for workflow reference: ${actionRef.owner}/${actionRef.repo}/${actionRef.repoPath}`
+    );
+    return [];
+  }
   const validationErrors = [];
   const shaRefValidation = validateShaRef(actionRef);
   const versionCommentValidation = validateVersionCommentExists(actionRef);
@@ -24116,12 +24122,6 @@ function validateVersionCommentExists(actionReference) {
   };
 }
 async function validateNodeActionVersion(octokit, actionRef) {
-  if (actionRef.isWorkflowFile) {
-    core3.debug(
-      `Skipping node version validation for ${actionRef.owner}/${actionRef.repo}/${actionRef.repoPath}`
-    );
-    return;
-  }
   const actionFile = await getActionFileFromGithub(
     octokit,
     actionRef.owner,
@@ -24194,7 +24194,7 @@ var ActionsRunnerValidation = class {
     this.options = options ?? {};
   }
   async validate(parsedFile) {
-    core4.debug(`Validating action references in ${parsedFile.filename}`);
+    core4.debug(`Validating gha runners in ${parsedFile.filename}`);
     const { filename } = parsedFile;
     const lineActionsRunners = mapAndFilterUndefined(
       parsedFile.lines,
@@ -24358,7 +24358,7 @@ var IgnoresCommentValidation = class {
     this.options = options ?? {};
   }
   async validate(parsedFile) {
-    core5.debug(`Validating action references in ${parsedFile.filename}`);
+    core5.debug(`Validating ignores comments in ${parsedFile.filename}`);
     const { filename } = parsedFile;
     const ignoreComments = mapAndFilterUndefined(
       parsedFile.lines,

diff --git a/actions/gha-workflow-validator/src/validations/action-reference-validations.ts b/actions/gha-workflow-validator/src/validations/action-reference-validations.ts
@@ -98,6 +98,13 @@ async function validateActionReference(
     return [];
   }
 
+  if (actionRef.isWorkflowFile) {
+    core.debug(
+      `Skipping validation for workflow reference: ${actionRef.owner}/${actionRef.repo}/${actionRef.repoPath}`,
+    );
+    return [];
+  }
+
   const validationErrors: ValidationMessage[] = [];
 
   const shaRefValidation = validateShaRef(actionRef);
@@ -151,13 +158,6 @@ async function validateNodeActionVersion(
   octokit: Octokit,
   actionRef: ActionReference,
 ): Promise<ValidationMessage | undefined> {
-  if (actionRef.isWorkflowFile) {
-    core.debug(
-      `Skipping node version validation for ${actionRef.owner}/${actionRef.repo}/${actionRef.repoPath}`,
-    );
-    return;
-  }
-
   const actionFile = await getActionFileFromGithub(
     octokit,
     actionRef.owner,

diff --git a/actions/gha-workflow-validator/src/validations/actions-runner-validations.ts b/actions/gha-workflow-validator/src/validations/actions-runner-validations.ts
@@ -30,7 +30,7 @@ export class ActionsRunnerValidation implements ValidationCheck {
   }
 
   async validate(parsedFile: ParsedFile): Promise<FileValidationResult> {
-    core.debug(`Validating action references in ${parsedFile.filename}`);
+    core.debug(`Validating gha runners in ${parsedFile.filename}`);
     const { filename } = parsedFile;
 
     const lineActionsRunners = mapAndFilterUndefined(

diff --git a/actions/gha-workflow-validator/src/validations/ignores-comment-validation.ts b/actions/gha-workflow-validator/src/validations/ignores-comment-validation.ts
@@ -22,7 +22,7 @@ export class IgnoresCommentValidation implements ValidationCheck {
   }
 
   async validate(parsedFile: ParsedFile): Promise<FileValidationResult> {
-    core.debug(`Validating action references in ${parsedFile.filename}`);
+    core.debug(`Validating ignores comments in ${parsedFile.filename}`);
     const { filename } = parsedFile;
 
     const ignoreComments = mapAndFilterUndefined(