Change FetchInitialMaxFinalizedBlockNumber interface #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmank88
reviewed
Jun 20, 2023
| @@ -181,7 +181,7 @@ type ReportCodec interface { | |||
| type Fetcher interface { | |||
| // FetchInitialMaxFinalizedBlockNumber should fetch the initial max | |||
| // finalized block number from the mercury server. | |||
| FetchInitialMaxFinalizedBlockNumber(context.Context) (int64, error) | |||
| FetchInitialMaxFinalizedBlockNumber(context.Context) (*int64, error) | |||
There was a problem hiding this comment.
nit/ did you consider using -1 instead of nil to avoid the signature change?
There was a problem hiding this comment.
Yes but it's even more confusing because -1 is actually a valid value that is used already
jmank88
approved these changes
Jun 20, 2023
samsondav
deleted the
MERC-954-mercury-feeds-should-probably-start-at-the-first-block-number-not-at-zero
branch
cedric-cordenier
pushed a commit
that referenced
this pull request
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.