golangci-lint: update rules to match core #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@samsondav WDYT about making these name changes to resolve all outstanding linter issues? Otherwise, we should switch the linter over to |
vyzaldysanchez
previously approved these changes
Apr 30, 2024
samsondav
previously approved these changes
May 10, 2024
samsondav
previously approved these changes
May 14, 2024
jmank88
force-pushed
the
golangci-lint
branch
2 times, most recently
from
6b2c423 to
28c6862
Compare
vyzaldysanchez
previously approved these changes
May 14, 2024
|
Fixed the tests |
vyzaldysanchez
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are only five outstanding problems. Four of them are exported names, so I only fixed the other one.