Benchmarking; add unit tests to LLO plugin; fix large channel add not working #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
samsondav
commented
Jun 26, 2024
•
samsondav
commented
- Use pbufs instead of json
- Implement binary codec for Outcome and Observation
- ** Add unit tests **
samsondav
force-pushed
the
MERC-5830-large-number-of-channels-1000-does-not-work
branch
from
3e3bc46 to
5de6e26
Compare
samsondav
force-pushed
the
MERC-5830-large-number-of-channels-1000-does-not-work
branch
3 times, most recently
from
4b1e248 to
291e59e
Compare
martin-cll
previously approved these changes
Jul 2, 2024
martin-cll
reviewed
Jul 2, 2024
| int64 unixTimestampNanoseconds = 3; | ||
| repeated uint32 removeChannelIDs = 4; | ||
| map<uint32, LLOChannelDefinitionProto> updateChannelDefinitions = 5; | ||
| map<uint32, bytes> streamValues = 6; |
There was a problem hiding this comment.
Would it be better to use a repeated messages instead of maps here? A map limits you to the provided key and value types only, but a repeated message gives you the option of adding more fields later on. e.g. you already have LLOStreamIDAndValue.
There was a problem hiding this comment.
Nah not necessary because Observation doesn't need to be serialized deterministically
- Use pbufs instead of json for Outcome and Observation - Implement "Update" which does add and replace instead of only add - Add some unit tests - Fix various bugs and nil crashes - Increase max channels - Add Verbose logging option - Performance improvements
samsondav
force-pushed
the
MERC-5830-large-number-of-channels-1000-does-not-work
branch
from
a5c208e to
0cbd3e0
Compare
samsondav
changed the title
akuzni2
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.