Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat): Add new rule: Named Mapping Parameters #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

justinkaseman
Copy link

Issue #11

Testing

Tested by adding the new rule into the chainlink-solhint-rules-example repository

Input
Counter.sol

// SPDX-License-Identifier: UNLICENSED
pragma solidity ^0.8.18;

contract Counter {
    constructor() {}
    mapping(bytes32 key => bytes32 value) private s_testMapping;
}

Output
image


Input
Counter.sol

// SPDX-License-Identifier: UNLICENSED
pragma solidity ^0.8.18;

contract Counter {
    constructor() {}
    mapping(bytes32 => bytes32) private s_testMapping;
}

Output
image


Input
Counter.sol

// SPDX-License-Identifier: UNLICENSED
pragma solidity ^0.8.13;

contract Counter {
    constructor() {}
    mapping(bytes32 => bytes32) private s_testMapping;
}

Output
image

Copy link

changeset-bot bot commented Feb 20, 2024

⚠️ No Changeset found

Latest commit: f1832af

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant