Skip to content

Commit

Permalink
Decouple config tests (#12971)
Browse files Browse the repository at this point in the history
* Add first version of evm utils

* Remove unused context util

* Add WSServer tests

* Add NewLegacyTransaction test

* Update NewTestChainScopedConfig to apply correct defaults

* Decouple config tests

* Move testutils

* Update paths

* Add default config validation

* Fix assert import

* Rename test method

* Use common multierror

* Fixes

* Add changeset

* Update dependencies
  • Loading branch information
dimriou committed Jun 4, 2024
1 parent d774ced commit a2441ba
Show file tree
Hide file tree
Showing 20 changed files with 167 additions and 501 deletions.
5 changes: 5 additions & 0 deletions .changeset/dry-doors-do.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"chainlink": minor
---

Decouple evm config tests from core #internal
6 changes: 3 additions & 3 deletions core/chains/evm/config/chain_scoped_ocr2_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@ import (

"github.com/stretchr/testify/require"

"github.com/smartcontractkit/chainlink/v2/core/internal/cltest"
"github.com/smartcontractkit/chainlink/v2/core/chains/evm/testutils"
)

func Test_ocr2Config(t *testing.T) {
evmOcrCfg := cltest.NewTestChainScopedConfig(t) //fallback.toml values
require.Equal(t, uint32(5400000), evmOcrCfg.EVM().OCR2().Automation().GasLimit())
cfg := testutils.NewTestChainScopedConfig(t, nil) //fallback.toml values
require.Equal(t, uint32(5400000), cfg.EVM().OCR2().Automation().GasLimit())
}
22 changes: 16 additions & 6 deletions core/chains/evm/config/chain_scoped_ocr_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,26 @@ package config_test

import (
"testing"
"time"

"github.com/stretchr/testify/require"

"github.com/smartcontractkit/chainlink/v2/core/internal/cltest"
"github.com/smartcontractkit/chainlink/v2/core/chains/evm/testutils"
)

func Test_ocrConfig(t *testing.T) {
evmOcrCfg := cltest.NewTestChainScopedConfig(t) //fallback.toml values
require.Equal(t, uint16(4), evmOcrCfg.EVM().OCR().ContractConfirmations())
require.Equal(t, cltest.MustParseDuration(t, "10s"), evmOcrCfg.EVM().OCR().ContractTransmitterTransmitTimeout())
require.Equal(t, cltest.MustParseDuration(t, "10s"), evmOcrCfg.EVM().OCR().DatabaseTimeout())
require.Equal(t, cltest.MustParseDuration(t, "1s"), evmOcrCfg.EVM().OCR().ObservationGracePeriod())
cfg := testutils.NewTestChainScopedConfig(t, nil) //fallback.toml values

require.Equal(t, uint16(4), cfg.EVM().OCR().ContractConfirmations())
require.Equal(t, mustParseDuration(t, "10s"), cfg.EVM().OCR().ContractTransmitterTransmitTimeout())
require.Equal(t, mustParseDuration(t, "10s"), cfg.EVM().OCR().DatabaseTimeout())
require.Equal(t, mustParseDuration(t, "1s"), cfg.EVM().OCR().ObservationGracePeriod())
}

func mustParseDuration(t testing.TB, durationStr string) time.Duration {
t.Helper()

duration, err := time.ParseDuration(durationStr)
require.NoError(t, err)
return duration
}
Loading

0 comments on commit a2441ba

Please sign in to comment.