Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(chore): Update Functions v1 single line comments to nat spec #10567

Merged
merged 6 commits into from
Sep 8, 2023
Merged

(chore): Update Functions v1 single line comments to nat spec #10567

merged 6 commits into from
Sep 8, 2023

Conversation

justinkaseman
Copy link
Contributor

Description

Updates // comments to be picked up by natspec by using ///
No lines changes that aren't comments

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

I see that you haven't updated any README files. Would it make sense to do so?

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6124685433

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6125057577

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6125719372

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6126238303

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6126260248

bolekk
bolekk previously approved these changes Sep 8, 2023
View reviewed changes
@justinkaseman justinkaseman added this pull request to the merge queue Sep 8, 2023
@justinkaseman justinkaseman removed this pull request from the merge queue due to a manual request Sep 8, 2023
@justinkaseman justinkaseman added this pull request to the merge queue Sep 8, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Sep 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6126944243

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6126983140

@justinkaseman justinkaseman added this pull request to the merge queue Sep 8, 2023
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Merged via the queue into develop with commit d3dfc5c Sep 8, 2023
142 checks passed
@justinkaseman justinkaseman deleted the chore/functions-nat-spec branch September 8, 2023 23:28
@snehaagni snehaagni mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bolekk bolekk bolekk approved these changes

@aelmanaa aelmanaa Awaiting requested review from aelmanaa

@KuphJr KuphJr Awaiting requested review from KuphJr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justinkaseman @bolekk