Add extra sanity checks to config poller and contract transmitter #10593
Conversation
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
|
Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6152926407 |
|
SonarQube Quality Gate
|
| @@ -162,6 +162,9 @@ func (cp *configPoller) LatestConfig(ctx context.Context, changedInBlock uint64) | |||
| if err != nil { | |||
| return ocrtypes.ContractConfig{}, err | |||
| } | |||
| if len(lgs) == 0 { | |||
| return ocrtypes.ContractConfig{}, errors.New("no logs found") | |||
There was a problem hiding this comment.
Does this always indicate an error or should we just warn here? For example, what if polling frequency is set to be more frequent than the rate of block production?
There was a problem hiding this comment.
Polling frequency doesn't matter. This method is used to fetch the latest config, with a known block number retrieved from LatestConfigDetails(). In fact this check should never fail and it likely never did in prod, otherwise we would've seen panics about underflow from the line below.
This PR is just being extra safe and having explicit errors.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
No description provided.